search

ejwa / gitinspector

:bar_chart: The statistical analysis tool for git repositories
GNU General Public License v3.0
2.36k stars 327 forks source link

fix some errors #115

Closed bigplum closed 7 years ago

bigplum commented 8 years ago

Fix some errors with multiple projects, if second project is empty:

  1. The ref will not be initial.
  2. Blame information will not shown.
  3. Fix Nonetype in commits.
adam-waldenberg commented 8 years ago

Thank you. I actually think the NoneType in commits issue is related to the threading code.... I will investigate and merge your contribution once I have looked into it more.

carera commented 8 years ago

Checked this one out, throws syntax error:

 File "gitinspector/gitinspector/changes.py", line 233
    else:
       ^
SyntaxError: invalid syntax

i guess the else expression is incorrectly indented

bigplum commented 8 years ago

It may caused by the spaces intent in my code.

adam-waldenberg commented 8 years ago

Going to take a look at this and also integrate parts of the pull request. A 0.4.5 release fixing this is most likely a good idea.

adam-waldenberg commented 7 years ago

@bigplum This got fixed now I believe. Solved using a slightly different solution with better error handling.

The issue with NoneType in commits can still happen, as there is a bug in the threading code. I will look into this. When the threading code is fixed this should (theoretically) never occur.

Let me know if any of the other issues still persists.