search

ejwa / gitinspector

:bar_chart: The statistical analysis tool for git repositories
GNU General Public License v3.0
2.36k stars 327 forks source link

Remove global interval.__ref__ to avoid race #132

Closed redbaron closed 7 years ago

redbaron commented 7 years ago

previously it was broken when multiple repos where exemined and '--since' was used: global interval.__ref__ was set to a commit ID valid for only one last examined repo, making it fail for all others

adam-waldenberg commented 7 years ago

@redbaron Thank you. Good catch. I'll try to include this in the next 0.4.5 release.

redbaron commented 7 years ago

Also piggyback change to skip submodules

adam-waldenberg commented 7 years ago

@redbaron This should be fixed. I decided to handle it slightly differently and with the same changes also fix a different issue happening when analyzing multiple repos, as seen in #115.

When it comes to submodules - I don't think we should skip them altogether. It's probably better to handle the fact that they have been removed. Maybe a new pull request handling this would be an idea. If you are up for it. People use submodules to merge statistics from multiple repos sometimes.

Let me know if any issues still persist related to ref.