search

ejwa / gitinspector

:bar_chart: The statistical analysis tool for git repositories
GNU General Public License v3.0
2.36k stars 328 forks source link

Configurable concurrency #96

Closed imposeren closed 8 years ago

imposeren commented 8 years ago

https://github.com/ejwa/gitinspector/issues/22#issuecomment-165788269 by @adam-waldenberg

Gitinspector starts as many processes as there are threads/cores. There is no configuration option for it, and never will be. However, there is a constant at the top of changes.py and blame.py that controls the number of threads.

Why there will never be such an option? I think that it's not hard to implement such an option. I was planning to submit pull request for this. What are the reasons against such an option?

Example

gitinspector --concurrency=2 ...
adam-waldenberg commented 8 years ago

@imposeren

The reason is that it's generally something that should be automatic. If the use case is to lower the impact on the system it's generally a better solution to just renice gitinspector and it's sub-processes.

adam-waldenberg commented 8 years ago

@imposeren

I don't know what system you are on... If it's a unix variant you can do something like;

nice -n15 ./gitinspector.py

... and you should be in business.

adam-waldenberg commented 8 years ago

There's no compelling argument for this feature, so I'm closing this.