search

ek5932 / EzeTest

0 stars 1 forks source link

Is an empty array intentional? #1

Open arseni-mourzenko opened 5 years ago

arseni-mourzenko commented 5 years ago

Not sure to understand why is there an empty array in a service. Looking at how it is initialized, it would always remain empty.

ek5932 commented 5 years ago

You are correct.

Originally I was injecting the collection via the ctor and was hoping it would support 0-many instances, but this was not the case and the sample wouldn't run. For the sake of getting it working I changed the ctor to init an empty array.

arseni-mourzenko commented 5 years ago

Got it. By the way, I switched from an array to a list in my pull request. Not sure if this is suitable.

ek5932 commented 5 years ago

It's fine. I approved the PR but didn't merge it. I prefer to operate that way in case whoever submitted the review doesn't actually want it merged straight away - but feel free to merge.

Also, I had a play with OpenShift on the weekend - it really seems like a cool bit of tech. If you watch this YouTube Video from 20:48 you can have a preview of what it does.

I installed it on a Fedora VM. I'm 95% of the way there (I followed this) but for some reason the auto-git build is failing to connect to github.com for the clone. It's weird cause it has net as it can pull containers. Once I get it working I'll see if I can expose the VM to the outside world so we can use it as a playground.

I'm also going to create a new project tonight or tomorrow (I'll see how I go with OpenShift) for the TestDefinition API. I want to plug an EventStore backend and do some tutorials. I gave up on the AuthServer stuff as I couldn't get Implcit flow working and I felt like looking at something more interesting.