support quotes & credentials in mirror config

ekalinin / nodeenv

Virtual environment for Node.js & integrator with virtualenv

http://ekalinin.github.io/nodeenv/

Other

1.7k stars 209 forks source link

support quotes & credentials in mirror config #322

Open Mythra opened 1 year ago

Mythra commented 1 year ago

fixes #321

this change performs two parts. The first is removing any extra quotes from the configuration file so the examples in the README work as expected.

The second is supporting HTTP Basic Authentication credentials within the mirror argument itself so for folks fetching from a source that requires authentication they are able to do so.

ekalinin commented 1 year ago

Hi, thanks for the patch!

Could you, please, add some tests?

Mythra commented 1 year ago

Hi! I'm not aware of any open source HTTP mirrors that would allow for sending authentication to them, is there perhaps a mirror you know of (or a way you were hoping to see it mocked? I don't see any mocks currently in tree).