ekalinin / nodeenv

Virtual environment for Node.js & integrator with virtualenv
http://ekalinin.github.io/nodeenv/
Other
1.71k stars 212 forks source link

Replace `setuptools` runtime dependency with `packaging` #337

Closed flying-sheep closed 1 year ago

flying-sheep commented 1 year ago

You import pkg_resources, which is deprecated. For object oriented handling of versions, you should use packaging.version instead.

grafik

anisse commented 1 year ago

In addition to the warning in the docs, it generates a warning in requirements.txt when using generating it with pip-compile :

# The following packages are considered to be unsafe in a requirements file:
setuptools==68.1.2 \
    --hash=sha256:3d4dfa6d95f1b101d695a6160a7626e15583af71a5f52176efa5d39a054d475d \
    --hash=sha256:3d8083eed2d13afc9426f227b24fd1659489ec107c0e86cec2ffdde5c92e790b
    # via nodeenv