search

ekalinin / nodeenv

Virtual environment for Node.js & integrator with virtualenv
http://ekalinin.github.io/nodeenv/
Other
1.71k stars 212 forks source link

Replace additional use of `which(1)` with `shutil.which()` #355

Open mgorny opened 6 months ago

mgorny commented 6 months ago

Replace the remaining use of external which(1) tool with shutil.which() from the standard Python library, finally removing the dependency on a third party package.

This is a followup to 1024f4f64ceabd612b4df9a0b9dbe2691b2f5f9d.

ekalinin commented 3 months ago

Hey! Thanks for the patch! Could you, please, add some test?

mgorny commented 3 months ago

What kind of test?

ekalinin commented 3 months ago

Unit test.

mgorny commented 3 months ago

install_activate is already covered by tests. I fail to see what I could test differently there.