ekaterinailin / AltaiPony

Find flares in Kepler and TESS light curves. Notebooks for quickstart inside.
https://altaipony.readthedocs.io
MIT License
26 stars 10 forks source link

Issue with flc.find_flares() #48

Closed afeinstein20 closed 5 years ago

afeinstein20 commented 5 years ago

Hi,

I was trying to find flares with TESS data and the find_flares() function didn't work right out of the box. This is because the detrended_flux_err is a requirement (or else it's defaulted to a list of NaNs), which I initially did not input as I wasn't using a lightkurve.lightcurve.LightCurve object. It would be wonderful if you could add this to the documentation :)

Additionally, for characterize_one_flare() (and please correct me if I'm wrong), the input should be a Pandas.DataFrame row. However, there were a lot of syntax errors when trying to manipulate the values in the rows in the function.

I've forked a version of AltaiPony that now works for me with these fixes. Can you confirm that this is the appropriate behavior of the code here? If it is, I will submit it as a pull request.

Thanks!