ekaterinailin / AltaiPony

Find flares in Kepler and TESS light curves. Notebooks for quickstart inside.
https://altaipony.readthedocs.io
MIT License
26 stars 10 forks source link

Pass detrended_flux and detrended_flux_err directly to constructor #68

Open ekaterinailin opened 3 years ago

ekaterinailin commented 3 years ago

At the moment, you can only pass 'flux' and 'flux_err' to 'FlareLightCurve'.

What needs to be created or improved?

We also want to pass 'detrended_flux' and 'detrended_flux_err' to 'FlareLightCurve' directly, too.

Can you provide an example?

This is how it works now:

lc = FlareLightCurve(data['TIME'])
lc["detrended_flux"] = data['detrended_flux']
lc["detrended_flux_err"] = data['detrended_flux_err']

# OR

lc = FlareLightCurve(data, targetid=999)
# data can be a simple dict or an astropy Table

This is how we may want it to work, too:

lc = FlareLightCurve(data['TIME'], detrended_flux=data['detrended_flux'], detrended_flux_err=data['detrended_flux_err'], )

What is the goal / expected behaviour?

chantalshine commented 3 years ago

Hello!

I would like the opportunity to work on this issue.

toihr commented 2 years ago

Is this still worked on?