search

ekazaev / ChatLayout

ChatLayout is an alternative solution to MessageKit. It uses custom UICollectionViewLayout to provide you full control over the presentation as well as all the tools available in UICollectionView. It supports dynamic cells and supplementary view sizes.
MIT License
898 stars 67 forks source link

Refactor some classes to have a readable and cleaner code base #31

Closed mehrankmlf closed 2 years ago

mehrankmlf commented 2 years ago

Refactor some classes to have a readable and cleaner code base.

ekazaev commented 2 years ago

@mehrankmlf Can you please briefly explain me what is the purpose of this PR? You just changed the order of some calls. But especially when it comes to constraints what is the difference? Is it your personal preference to set top and bottom anchors before leading and trailing?

mehrankmlf commented 2 years ago

Hi,

I was looking at the source code and I realized that by changing some parts can have a readable source code, if this PR doesn't meet your standards, I will cancel it.

Best Regards, Mehran Kamalifard

On Tir 9, 1401 AP, at 14:08, Eugene Kazaev @.***> wrote:

@mehrankmlf https://github.com/mehrankmlf Can you please briefly explain me what is the purpose of this PR? You just changed the order of some calls. But especially when it comes to constraints what is the difference? Is it your personal preference to set top and bottom anchors before leading and trailing?

— Reply to this email directly, view it on GitHub https://github.com/ekazaev/ChatLayout/pull/31#issuecomment-1170992784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3DJ54ZICARCYR3PEXO22LVRVTHZANCNFSM5ZTBVLJQ. You are receiving this because you were mentioned.

ekazaev commented 2 years ago

@mehrankmlf No, no. I did not mean that. Rearanging calls in finalize function probably has sense. But with the constraints it feels more like a personal preference rather than making code cleaner