search

ekazaev / route-composer

Protocol oriented, Cocoa UI abstractions based library that helps to handle view controllers composition, navigation and deep linking tasks in the iOS application. Can be used as the universal replacement for the Coordinator pattern.
MIT License
896 stars 63 forks source link

Fix optionally hanging CATransaction #49

Closed Elaz-viz closed 4 years ago

Elaz-viz commented 4 years ago

part of the navigation process might be not animated. In this case, the CATransaction should not be registered as the invoker of the completion block because there will be no animation.

codecov[bot] commented 4 years ago

Codecov Report

Merging #49 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   96.42%   96.44%   +0.01%     
==========================================
  Files         103      103              
  Lines        2685     2697      +12     
==========================================
+ Hits         2589     2601      +12     
  Misses         96       96
Impacted Files Coverage Δ
...Classes/Adapters/NavigationControllerAdapter.swift 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b964e6...3a0bffa. Read the comment docs.