search

ekazaev / route-composer

Protocol oriented, Cocoa UI abstractions based library that helps to handle view controllers composition, navigation and deep linking tasks in the iOS application. Can be used as the universal replacement for the Coordinator pattern.
MIT License
902 stars 64 forks source link

make compatible to build for targets with app extensions #67

Closed max-potapov closed 3 years ago

max-potapov commented 3 years ago

reproduced with Xcode 13 beta 3

ekazaev commented 3 years ago

@max-potapov Does it need to be added anywhere else? I haven't tested it myself with app extensions 😱

max-potapov commented 3 years ago

@max-potapov Does it need to be added anywhere else? I haven't tested it myself with app extensions 😱

So, my project is still failing, but this framework looks good now. Basically you can check by search UIApplication.shared calls which can't be called from app extensions code.

max-potapov commented 3 years ago

Unfortunately the work is not finished. I'm closing this for now and I'll re-open it when all work will be done

ekazaev commented 3 years ago

@max-potapov I see. Please let me know if I can help you

max-potapov commented 3 years ago

@ekazaev it's seems that this bug is related to SPM and we don't need to fix it because we use this library only in main app and not in extensions. Here is a link: https://bugs.swift.org/browse/SR-14944

ekazaev commented 3 years ago

@max-potapov Oh crap. Sorry about that. May be some temporary workaround is needed?

max-potapov commented 3 years ago

@max-potapov Oh crap. Sorry about that. May be some temporary workaround is needed?

I would suggest to wait next Tuesday may be beta 4 will be available

max-potapov commented 3 years ago

Didn't check the latest beta but workaround is to use CocoaPods instead of SPM. Maybe this hint can help someone :)

ekazaev commented 3 years ago

@max-potapov thank you. Classic apple