search

ekeeke / Genesis-Plus-GX

An enhanced port of Genesis Plus - accurate & portable Sega 8/16 bit emulator
Other
673 stars 193 forks source link

[Libretro] Multi-line cheats crash the core #468

Closed ds22x closed 1 year ago

ds22x commented 1 year ago

https://github.com/ekeeke/Genesis-Plus-GX/commit/98b5c603557f0ce3bbf347c2f75c1412288ec66c is causing crashes when enabling multi-line cheat codes in RetroArch. Tested the commit with both the upstream and the downstream cores, and both exhibit the same issue (tested on x86-64 Windows 11).

Edit: Seems to have already been reported here: https://github.com/ekeeke/Genesis-Plus-GX/issues/445#issuecomment-1288135110

ekeeke commented 1 year ago

Indeed, looks like I completely messed up when backporting changes from the gamecube/wii port into libretro.c and that commit actually broke cheat support in the libretro core.

I will submit a fix shortly, thanks for the report

ekeeke commented 1 year ago

Should now be fixed after https://github.com/ekeeke/Genesis-Plus-GX/commit/90bb356a173dc1010d6694bdb470c176efd9c03b

ds22x commented 1 year ago

Glad to help, and thanks for the fix.