search

ekeeke / Genesis-Plus-GX

An enhanced port of Genesis Plus - accurate & portable Sega 8/16 bit emulator
Other
673 stars 193 forks source link

[libretro] Port Backup Ram Cart changes from downstream #498

Closed ichee closed 1 year ago

ichee commented 1 year ago

Add an option for the backup ram cart to be configurable per-cart or per-game.

Ported from downstream #326.

ekeeke commented 1 year ago

Is there a real need or use case for this option ? It makes sense for internal backup RAM whose size is too small for all games but RAM cart is 512KB and the number of games supporting it very limited so I have doubts that, even all together, they could ever reach the max available size.

ichee commented 1 year ago

The change is mostly for consistency with internal ram, as well as user choice, even if it may seem meaningless.

There are at least, or very near, three dozen games I could research that supported the backup ram cart, and considering that many users, myself included, would make numerous saves for each game, it could be very possible to exhaust available ram.

This could also become relevant if an option to set the size of the backup ram cart were available, since the official size was just 1Mbit, far more likely to max out.

Granted, the above examples would mostly cater to the more obsessive users, but, regardless, it doesn’t hurt anything nor over-complicate the codebase.

ekeeke commented 1 year ago

Ok, just be aware that when enabled, it will create 512KB files for each CD game you play, even if the game does not use (or even support) the RAM cart, which could be considered as not meaningless by some users.