A lot dma fill fails in vdp port access test rom

ekeeke / Genesis-Plus-GX

An enhanced port of Genesis Plus - accurate & portable Sega 8/16 bit emulator

Other

672 stars 193 forks source link

A lot dma fill fails in vdp port access test rom #542

Closed SN902 closed 4 months ago

SN902 commented 4 months ago

Before there was only 1-2 fails, now 25 VDPFIFOTesting.zip

ekeeke commented 4 months ago

Indeed, I introduced a stupid regression when attempting to improve DMA fill timings in a recent commit, which totally broke DMA fill (probably also affect many MD games), thanks for the report.

I reverted the change in https://github.com/ekeeke/Genesis-Plus-GX/commit/5af254cd23b0129204dd08419fde3c234de78bb4 and implemented (hopefully) proper DMA fill timing improvement in https://github.com/ekeeke/Genesis-Plus-GX/commit/8c72ba0d4557aab4bbbae05a0c6b1382d23b4e74