ekeeke / Genesis-Plus-GX

An enhanced port of Genesis Plus - accurate & portable Sega 8/16 bit emulator
Other
671 stars 193 forks source link

additional NTSC filters #563

Closed SpelzR2 closed 2 days ago

SpelzR2 commented 5 days ago

Is there any chance to integrate the advanced NTSC-Blargg filters by Cyber (provided in RetroArch) into the emulator and choose them in the core options like the current NTSC filters? Especially the S-Video one has some advantages over the old Blargg filters:

Filters in RetroArch: filters

Sonic 1 NTSC Blargg (Composite): Sonic the Hedgehog (Sonic 1 Bugfix Hack)-240627-232511

Sonic 1 NTSC Blargg by Cyber: Sonic the Hedgehog (Sonic 1 Bugfix Hack)-240627-232534

ekeeke commented 2 days ago

I am not sure to understand why do you want to have this filter as a core setting if you can already use them through retroarch filter settings ? What difference does it make ? Anyway, I do not really want to include another NTSC filter, especially a SNES NTSC filter, when the existing MD ones can already be customized and could probably produce the same results as the SNES one with appropriate settings. Looking at your pictures, I hardly see any differences between them, so it's probably only a matter of making custom MD / SMS NTSC filter setup. For the record, this can already be done in the standalone GC/Wii port by setting NTSC filter setting to MANUAL and adjusting the available NTSC settings (sharpness, hue, fringing, etc) as you prefer. This could easily be done too in libretro core settings but you will have to ask libretro devs for that.