search

ekeric13 / react-star-ratings

A customizable svg star rating component for selecting x stars or visualizing x stars
https://codepen.io/ekeric13/project/full/DkJYpA/
BSD 3-Clause "New" or "Revised" License
152 stars 44 forks source link

Add TypeScript typings #27

Open pschyma opened 5 years ago

pschyma commented 5 years ago

This PR adds typings to allow for an easier integration in TypeScript based projects.

All types are extracted from the source files and the documentation. Here the values found in the source code take precedence. For example the type of the changeRating handler is ((rating, name?) => void) | null with a default of null instead of () => {} like stated in the documentation.

This also fixes #10 in TypeScript projects, because I added the corresponding property to the component, since the feature is already implemented but the propTypes lack the correspondig property whilst its default is set to Star.

ergofriend commented 5 years ago

Pls create a new npm package for typescript :)

blimpmason commented 4 years ago

When will this be merged?

mayinghan commented 3 years ago

can this pr get merged?