ekg / seqwish

alignment to variation graph inducer
MIT License
143 stars 18 forks source link

Do not use -latomic on macOS #119

Open kojix2 opened 10 months ago

kojix2 commented 10 months ago

This pull request is to avoid specifying -latomic on macOS.

I refer to the following pull request.

ekg commented 10 months ago

I can't test this. Does it work?

On Tue, Nov 14, 2023 at 11:12 PM kojix2 @.***> wrote:

This pull request is to avoid specifying -latomic on macOS.

I refer to the following pull request.


You can view, comment on, or merge this pull request online at:

https://github.com/ekg/seqwish/pull/119 Commit Summary

File Changes

(1 file https://github.com/ekg/seqwish/pull/119/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/ekg/seqwish/pull/119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEJY3CSRDLK7JWARQHDYERFLJAVCNFSM6AAAAAA7L47AHGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TIMBWGAYTGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kojix2 commented 10 months ago
# add the "-latomic" option only if the system name is not "Darwin.
$<$<NOT:$<STREQUAL:${CMAKE_SYSTEM_NAME},Darwin>>:-latomic>

It works on my Mac mini. There are no errors related to -latomic. Although, this code was suggested by ChatGPT, after all...