search

ekg / seqwish

alignment to variation graph inducer
MIT License
143 stars 18 forks source link

Make range extension really respect orientation when considering sequence starts and ends #39

Closed ekg closed 4 years ago

ekg commented 4 years ago

I ran into the same kind of bug that I thought we'd eliminated with a recent commit.

It turns out that the range extension code which checked for sequence starts as a reason to break the range extension was only doing so correctly for the reverse strand. This makes it fully stranded and correct. It also pushes one of the tests back to its previous md5, which matched the (much simpler, and likely correct) version that I'd established before implementing parallel union find.

bgruening commented 4 years ago

Thanks @ekg for working in this!

bgruening commented 4 years ago

If you could make a point release with this included that would be awesome. Otherwise I can patch the package.