search

ekibun / flutter_qjs

A quickjs engine for flutter.
https://pub.dev/packages/flutter_qjs
MIT License
146 stars 28 forks source link

[BUG] JSTag value mismatching because of int32 value conversion #23

Closed narumi147 closed 2 years ago

narumi147 commented 3 years ago

After upgrading to flutter 2.7, a string eval result always return null. Flutter 2.6 works.

Android real device(arm64) has such error. Windows, macOS, iOS and Android Emulator(Google x86_64) work.

Tries to test on flutter_js, find it was extended of this package, the same error there: https://github.com/abner/flutter_js/issues/65

As the solution provided in above issue, convert int_32 to int_64, everything works.

int_32 and int_64 variables with same value won't be matched in switch-case ? I'm not sure anywhere else may have similar bug because of int_32.

Unicellular-SU commented 2 years ago

I have the same problem.

narumi147 commented 2 years ago

https://github.com/abner/flutter_js/commit/d4aa7238e99eb30edb0924394f26af7a7711d316

That's quite a quick fix. If you have time, please release a new version.

narumi147 commented 2 years ago

Could you pls apply the quick fix for the new release?

ekibun commented 2 years ago

Sorry for late reply.

I have upgraded Flutter to 2.11 and tested in my Huawei device and no errors found. Is the bug still existed?

narumi147 commented 2 years ago

It seems fixed in the latest flutter :thinking: