Open ekilah opened 9 years ago
:+1: Excellent work, Monroe. Great thinking to add your additional features as well. Few notes after checking the code:
Parcelable
instead of Serializable
SwipeableRelativeLayout
feature, reduces the number of user clicks drastically. Might consider using a ViewPager for the same (in future) as well.Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
/cc @codepathreview @codepath
Got a lot done in a little span of time since I'm on vacation starting today. Still pretty happy with it!
PS - don't bother looking too hard at my
SearchSettings
class.. I made some design decisions early on without remembering I had to also implement the site search, so that class could definitely use refactoring. Functional though! Spent the time on the UI/UX instead of that since the settings still work.