Unit tests

[ekinhbayar]

Includes coding style fixes along with Client/RequestTest and Storage/RedisCounterTest so far. @PeeHaa, would you please review and hint me on what else you think needs to be tested? :-)

[PeeHaa]

I messed up the review I think. I started a review, but accidentally click "single comment" and my review was turned into separate comments. :-(

I've also added some comments on "outdated" commits which should still be checked.

[PeeHaa]

@ekinhbayar I have fixed the GitAmp tests https://gist.github.com/PeeHaa/796068f5e3b3e4c160e6dedf079dd5f2.

It now uses mocks which has several benefits:

• the unit tests never actually call the github service, but instead use mocks which makes the tests:
  • run faster
  • independent on an external service
  • independent of secret credentials
  • test only this specific class and not the entire amp stack (e.g. the artax client)
• the mocks can throw exceptions where needed for testing purposes
• we have total control over the flow when testing
• we have isolated tests now

The same idea applies to the RedisCounter test. Instead of relying on redis being available. And running non isolated tests which also include amp/redis we can instead use a mock RedisClient without ever going through the amp/redis stack or ever sending actually things over to a redis server.

I didn't write the redis tests yet, because I thought you may want to try to rewrite them using mocks.