search

ekinhbayar / gitamp

Listen to music generated by events across github.
MIT License
29 stars 10 forks source link

Change visibility of properties #3

Closed PeeHaa closed 7 years ago

PeeHaa commented 7 years ago

These can be made private / protected: https://github.com/ekinhbayar/gitamp/blob/master/src/Events/GithubEvent.php#L21-L29

ekinhbayar commented 7 years ago

That means we should not json_encode the array of objects then. IIRC if they were not public encoded values of property names are different.

PeeHaa commented 7 years ago

Oh I missed it we are doing that. Let me look.

PeeHaa commented 7 years ago

Yes. Good point. Need to give this one some more thought.

PeeHaa commented 7 years ago

Ohhh apparently that monster push I just did also solved this... \o/

That's an side effect I like.