search

ekinhbayar / gitamp

Listen to music generated by events across github.
MIT License
29 stars 10 forks source link

Properly handle connection errors #30

Closed PeeHaa closed 7 years ago

PeeHaa commented 7 years ago

Don't let the connection error exception bubble all the way but instead just return an empty Result object.

This may be hard to debug / find out when / why this happens so we probably want to introduce logging.

PeeHaa commented 7 years ago

Even after properly handling connection errors once dnslib is fucked it's FUBAR.

See #26

PeeHaa commented 7 years ago

Closed by https://github.com/ekinhbayar/gitamp/commit/a4de8a1d00ff5b227bb7ce7a723e43293b1282a4