search

ekinhbayar / gitamp

Listen to music generated by events across github.
MIT License
29 stars 10 forks source link

Setup CI and tests #6

Closed PeeHaa closed 7 years ago

PeeHaa commented 7 years ago
PeeHaa commented 7 years ago

@ekinhbayar could you add the repo to scrutinizer and travis in preparation of above please?

ekinhbayar commented 7 years ago

Done. Also made a head start for missing tests on unit-tests branch but still unsure about the Storage one I have there.

ekinhbayar commented 7 years ago

Scrutinizer has a CS checker in place. I think I haven't added CS checks to Travis CI anywhere yet.

Also I added the mention-bot webhook in repo settings, not sure if I need to anything else than that, it's only watching new PR's @PeeHaa.

PeeHaa commented 7 years ago

All tests are written. Pretty sure the RedisCounter is also covered.

I have opened an issue on the code-coverage repo https://github.com/sebastianbergmann/php-code-coverage/issues/501

PeeHaa commented 7 years ago

It looks like there is/was an issue with function imports. Using fqn fixed the code coverage https://github.com/ekinhbayar/gitamp/commit/174b22b8de0fdfe28638aef9edbef70ccb1f193b.

It looks like the latest code-coverage release will fix the issue, but it's changelog is... uhhhmm.. not helpful at all.

PeeHaa commented 7 years ago

Updating the dependencies indeed fixed the coverage issue we were seeing. So this is fixed in https://github.com/ekinhbayar/gitamp/commit/9e7d3efc17ab232383ff0253514c9c566a07115c

PeeHaa commented 7 years ago

Closing this issue for now, because I am annoyed by the issue hanging on a single thing.

If we want to try to add the cs fixer in the future again just open a new issue for it.