fix(optimizeImageTrait): set translator property to protected

ekino / EkinoTinyPngSonataMediaBundle

A Symfony bundle to optimize sonata media images through tinyPNG API

MIT License

1 stars 4 forks source link

fix(optimizeImageTrait): set translator property to protected #5

Closed wjehanne closed 5 years ago

wjehanne commented 5 years ago

I am targeting this branch, because I have a conflict with sonata AbastractAdmin.

Changelog

### Fixed
- Replace visibility of $translator variable

To do

[ ] replace private by protected

Subject

I have a conflict with visibility of variable $translator in sonata abstact admin class.

coveralls commented 5 years ago

Coverage remained the same at 49.333% when pulling 27f1cf0c7ed817e33a934f81129a1526142da2f2 on williamjehanne:master-william into 7c2d6b713cdbf6bf8be2bd2917f63c35b74152e1 on ekino:master.

coveralls commented 5 years ago

Coverage remained the same at 49.333% when pulling 27f1cf0c7ed817e33a934f81129a1526142da2f2 on williamjehanne:master-william into 7c2d6b713cdbf6bf8be2bd2917f63c35b74152e1 on ekino:master.

mremi commented 5 years ago

@williamjehanne can you explain please?