Hey there, I reviewed v6y code and here are the items which stood out :)
v6y-front
Use i18next
*QueryType interface => could these types be factorized to avoid duplicating them? The only changing part is the name of the query which (to me) has no practical use to be here.
Fix Cannot find name React :
global-error.tsx
loading.tsx
not-found.tsx
Dynamic imports : disable eslint (react/display-name) or use a named function for the component returned by loading
VitalityAuditReportsTypeGrouper.tsx:31-38 => I don't get the conditions
Hey there, I reviewed v6y code and here are the items which stood out :)
v6y-front
i18next
*QueryType
interface => could these types be factorized to avoid duplicating them? The only changing part is the name of the query which (to me) has no practical use to be here.Cannot find name React
:global-error.tsx
loading.tsx
not-found.tsx
eslint (react/display-name)
or use a named function for the component returned by loadingVitalityAuditReportsTypeGrouper.tsx:31-38
=> I don't get the conditionsv6y-front-bo
getData
to avoid code duplication?Refine*Wrapper
=> data is inferred as unknownUseNavigationAdapter
is used in both this package and v6y-front => move it to v6y-commons ?Congrats for the current work :muscle: