search

ekino / veggies

:sparkles: :rocket: Veggies is an awesome cucumberjs library for API/CLI testing. Great for testing APIs built upon Express, Koa, HAPI, Loopback and others. It's also the perfect companion for testing CLI applications built with commander, meow & Co.
https://ekino.github.io/veggies/
MIT License
90 stars 18 forks source link

chore(deps): upgrade cucumber v8 #90

Closed tduyng closed 2 years ago

tduyng commented 2 years ago

Close #88

Crow-EH commented 2 years ago

You shouldn't commit tests/cli/dummy_features/__snapshots__/clean_snapshots.feature.snap and tests/cli/dummy_features/__snapshots__/update_snapshots.feature.snap: They are supposed to be changed by the tests, but should be left as is for the tests to be useful.

Otherwise, LGTM 👍

tduyng commented 2 years ago

You shouldn't commit tests/cli/dummy_features/__snapshots__/clean_snapshots.feature.snap and tests/cli/dummy_features/__snapshots__/update_snapshots.feature.snap: They are supposed to be changed by the tests, but should be left as is for the tests to be useful.

Otherwise, LGTM 👍

Thank Yohan so much ❤️. I waited for this review a long time 😂. . But there's no one yet. You are the best.

(I don't know we always want to remain theses snapshots, so I commit them after run the command test-cli. Ok I see the thing now. They are already restored).

Crow-EH commented 2 years ago

Great.

I've been ousted from the @ekino group so you'll have to ask @pebie to merge

pebie commented 2 years ago

Why is the yarn interactive tools plugin installed ?

tduyng commented 2 years ago

Why is the yarn interactive tools plugin installed ?

I think this plugin could be very useful. When I started to do this task, I want to create another commit to upgrade other dependencies. Some test failed and it need some modifications for the compatibility.

But if I do it, it makes so much noise for the task cucumber v8. I will take that later.

So maybe better I will remove this plugin from this PR.

pebie commented 2 years ago

Why is the yarn interactive tools plugin installed ?

I think this plugin could be very useful. When I started to do this task, I want to create another commit to upgrade other dependencies. Some test failed and it need some modifications for the compatibility.

But if I do it, it make so much noise for the task cucumber v8. I will take that later.

So maybe better I will remove this plugin from this PR.

Yes do another PR which explains why do you need this plugin. In this one there is no need to install this plugin. So yes, it makes noise.

tduyng commented 2 years ago

Why is the yarn interactive tools plugin installed ?

I think this plugin could be very useful. When I started to do this task, I want to create another commit to upgrade other dependencies. Some test failed and it need some modifications for the compatibility. But if I do it, it make so much noise for the task cucumber v8. I will take that later. So maybe better I will remove this plugin from this PR.

Yes do another PR which explains why do you need this plugin. In this one there is no need to install this plugin. So yes, it makes noise.

Ok, agree with that. I removed all the changes of yarn.yaml and plugins. I'll create another PR later.