ekisu / mpv-webm

Simple WebM maker for mpv, with no external dependencies.
MIT License
571 stars 33 forks source link

raw_observe_property (string expected, got function) #10

Closed Flat closed 6 years ago

Flat commented 6 years ago
mpv 0.27.0-416-g386e8cd16d (C) 2000-2017 mpv/MPlayer/mplayer2 projects
 built on Fri Nov 24 16:14:12 EST 2017
ffmpeg library versions:
   libavutil       56.0.100
   libavcodec      58.4.102
   libavformat     58.2.102
   libswscale      5.0.101
   libavfilter     7.2.100
   libswresample   3.0.101
ffmpeg version: N-89178-ga1630b40e8

When trying to start the script with Shift+w I get the following error.

[webm]
[webm] stack traceback:
[webm]  [C]: in function 'raw_observe_property'
[webm]  mp.defaults:351: in function 'observe_property'
[webm]  /home/flat/.config/mpv/scripts/webm.lua:791: in function 'observe_properties'
[webm]  /home/flat/.config/mpv/scripts/webm.lua:813: in function </home/flat/.config/mpv/scripts/webm.lua:811>
[webm]  (tail call): ?
[webm]  mp.defaults:202: in function 'fn'
[webm]  mp.defaults:60: in function 'handler'
[webm]  mp.defaults:339: in function 'handler'
[webm]  mp.defaults:458: in function 'call_event_handlers'
[webm]  mp.defaults:495: in function 'dispatch_events'
[webm]  mp.defaults:451: in function <mp.defaults:450>
[webm]  [C]: ?
[webm]  [C]: ?
[webm] Lua error: mp.defaults:351: bad argument #3 to 'raw_observe_property' (string expected, got function)
ekisu commented 6 years ago

Should be working now, see 9bbae70. I wonder how that didn't cause an error for me...

Flat commented 6 years ago

Works fine now, thanks! Was it changed upstream recently, or has it always required three arguments?

ekisu commented 6 years ago

It always required three arguments (git blame on defaults.lua says observe_property wasn't touched in the last 4 years), I just forgot it, and it, somehow, "worked" without crashes for me.