Closed winneon closed 5 years ago
I kinda expected this issue to appear sometime. I'll need to look if/how using an external crop affects the crop the script does.
Should work now.
The script properly crops it now, but it doesn't look where the x & y starting coordinates are. If you cropped in the middle of the screen with the boundaries not near the boundaries of the source video, the script will just encode the crop set at x = 0, y = 0, up in the top left corner, ignoring the coordinates.
Could you test this build? It seems to work for me, but allowing double crop/scale filters still kinda bugs me.
I had to run errands, when I get back I’ll check. Apologies.
On Sat, Feb 24, 2018 at 18:10 Ramon Dantas notifications@github.com wrote:
Could you test this build https://github.com/ElegantMonkey/mpv-webm/blob/no-crop-filter-handling/build/webm.lua? It seems to work for me, but allowing double crop/scale filters still kinda bugs me.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ElegantMonkey/mpv-webm/issues/14#issuecomment-368270783, or mute the thread https://github.com/notifications/unsubscribe-auth/AEEls-ttP7DXYcHWLGrR3OzKs41n0o_Kks5tYKTcgaJpZM4SLUy9 .
--
Jesse
This one's pretty simple. The encoding process ignores currently applied filters. The easiest way to reproduce this is to apply an external crop that was not applied with the mpv-webm script, such as adding the following to
input.conf
and pressingX
when watching a 1080p video.The end result is expected to follow the applied crop filter, focusing on the center of the video. Instead, the entire resolution is captured, ignoring the filter entirely.