search

ekisu / mpv-webm

Simple WebM maker for mpv, with no external dependencies.
MIT License
554 stars 32 forks source link

fix avc-nvenc format #175

Closed dsetareh closed 11 months ago

dsetareh commented 11 months ago

Could easily be just a me issue, but nvenc encodes always seem to fail with 'pts () < dts () in stream 0 errors without this flag.

I'm on windows and have a ampere gpu if that's any help.

ekisu commented 11 months ago

Does setting bframes to 0 work? Something like --ovcopts-add=bf=0. There's a similar issue on #117.

If it doesn't, this is fine to me I guess

dsetareh commented 11 months ago

Yup, that worked. I'll close this as I assume it's a worse fix. Can I ask why that change hasn't been made to the plugin? I assume there's a good reason, just curious.

Thanks for the help nonetheless! Been using this plugin for years and love it

ekisu commented 11 months ago

No special reason really, I just have little motivation to work on the script - adding new stuff would pretty much require a rewrite due to how convoluted the code is; and most of the major bugs (VP9 2-pass, for example) really cannot be fixed without changing things upstream (and given mpv's encoding part is pretty much deprecated, I don't really see those happening)

I still look at PRs from time to time, and as long as the script works for the essential stuff it's fine to me