search

ekk-cb / test-dest

0 stars 0 forks source link

6 case limit #33

Open ekk-cb opened 3 years ago

ekk-cb commented 3 years ago

Any specific reason to limit the number of fields to 6? Are patches welcome there?

ID: 3 Original Author: dispalt ID: 3 Original Author: ekk-cb

ekk-cb commented 3 years ago

Any specific reason to limit the number of fields to 6?

I got tired of copy & pasting over and over =<

Are patches welcome there?

Here's one problem: I've been thinking of converting the serialization format for case classes to be a javascript map {a: b, c: d} rather than a javascript list [b, d] that it is now. Such a change would involve a significant rewrite of the case-class read-write macro. Apart from making case classes map to javascript objects more "naturally", doing that would dodge this issue entirely. Any increase in arity probably is going to get stomped over by this semantic change the next time I publish a stable version anyway.

Original Author:lihaoyi Original Author:ekk-cb

ekk-cb commented 3 years ago

I am actually really happy you're going to make that change, thanks for the insight. The JSON produced right now doesn't map well to using other services.

Original Author:dispalt Original Author:ekk-cb

ekk-cb commented 3 years ago

Just published 0.1.7, which increases the limit on tuples and case classes to 22, and maps case classes to dicts rather than lists.

Original Author:lihaoyi Original Author:ekk-cb

ekk-cb commented 3 years ago

Thanks!

Original Author:dispalt Original Author:ekk-cb