ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 157 forks source link

fix highlight problem with common usernames #154

Closed narula closed 7 years ago

narula commented 8 years ago

Very hacky attempt at not highlighting four common english words just because someone in the slack has selected one of them as a username.

narula commented 8 years ago

I am happy to do this in a more robust way if you can point me in the right direction!

ekmartin commented 8 years ago

Hi! Did you see the comments over at #132? I think there's a few options here:

For large channels I think the last one might be better, as users could still highlight people with @ manually, but I'm not sure. Between the first two I think I'd prefer the second, as I still feel like it's a bit of a painful thing to configure.

What do you think?

btcdrak commented 8 years ago

I would actually take 1 and 3 as it gives power to the bot administrator. I'd have no problem with adding the odd word or two to an array. The problem with option 2 is you are bound to get the odd user complain they cant blacklist something not in the top100list and that would be a maintenance nightmare.

ekmartin commented 7 years ago

Hi! I'm gonna close this, as I think one of the suggested approaches above is a better direction to go. If you or anyone else want to send a pull request I'd be happy to discuss in slack-irc's Gitter!