search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 157 forks source link

When multiple links are included in a Slack message, only one link appears on IRC (the message is cut) #160

Closed japsu closed 7 years ago

japsu commented 7 years ago

Using latest HEAD from today. Been riddled with this problem for a long time, though.

Steps to reproduce: Say tracon.fi desucon.fi on a connected channel in Slack

Expected results: <yournick> tracon.fi desucon.fi is reproduced in IRC

Actual results: <yournick> desucon.fi in IRC

Also happens with e-mail addresses.

ekmartin commented 7 years ago

Woops! Thanks. Should be fixed in version 3.8.3.

japsu commented 7 years ago

Thanks @ekmartin for the super-fast reply.

Unfortunately, running version 3.8.3, I'm still experiencing the same problem.

This works: https://desucon.fi https://tracon.fi This doesn't: desucon.fi tracon.fi

If it makes any difference, I'm trying this on a private channel (no #).

Environment:

Running this docker image https://hub.docker.com/r/tracon/slackirc/ built from this Dockerfile https://github.com/tracon/ansible-tracon/blob/master/roles/slackirc/Dockerfile

ekmartin commented 7 years ago

Sorry, had to make the readable representation regex non-greedy as well: https://github.com/ekmartin/slack-irc/commit/1ffd30fd3cf4a61a0fbc052ff5d600bf63f4da0e

Please give version 3.8.4 a go and see if it fixes it. Thanks for the thorough report!

japsu commented 7 years ago

Thanks, working now!

japsu commented 7 years ago

@ekmartin I assume this is related:

Say in Slack: java.util.List<java.lang.String>

Appears in IRC: java.util.Listjava.lang.String

ekmartin commented 7 years ago

😞 - I'll take a look at it later :)

japsu commented 7 years ago

@jlaunonen just submitted a PR that probably fixes that :)

https://github.com/ekmartin/slack-irc/pull/161