Closed laughinghan closed 7 years ago
@ekmartin: lol did you add Coveralls twice or something
Brilliant! I agree with what you said in https://github.com/ekmartin/slack-irc/issues/56#issuecomment-258967286 - let's go with $username (IRC)
as the default. Whether it's a breaking change or not is up for discussion, but I think it's fine to just do it in a minor version bump, since as you said - it's a cosmetic change.
Should this maybe be nested under an object, to make it cleaner to add support for IRC username formatting as well?
"usernameFormat": {
"slack": "$username (IRC)",
"irc": "<$username>"
}
Or do you think it's clearer with just slackUsernameFormat
and ircUsernameFormat
?
EDIT: No idea what's happening with coveralls, let's see if it's a one-time incident ¯\_(ツ)_/¯
Great! Will do.
I don't think it should be nested, but I also see no use for ircUsernameFormat
since messages in IRC from the bot (piped from Slack) are already distinguished by coming from the bot, much moreso than bot messages in Slack.
I think one use case would be if people for some reason would want to remove the username when messages are posted to IRC. Might be good to have both just for unity, but we can merge this and look at it later.
@ekmartin: eh yeah let's just deal with that later. Updated default Slack username format.
Great, thanks! I'll create a release later.
Close #56