search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 158 forks source link

ignore irc messages starting with [off] #185

Closed MichaelDaum closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 98.925% when pulling b1adf422ffb11861d758d69501534e09d2a795a5 on MichaelDaum:master into d168ebc8a47eb4c47edb14cb6192936a8188698b on ekmartin:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 98.925% when pulling b1adf422ffb11861d758d69501534e09d2a795a5 on MichaelDaum:master into d168ebc8a47eb4c47edb14cb6192936a8188698b on ekmartin:master.

ekmartin commented 7 years ago

This seems very specific. Care to elaborate?

MichaelDaum commented 7 years ago

Yes, well, we've got an IRC logger monitoring our main channel of the community. Sometimes we like to exclude private messages or any other message not meant to be archived from being stored in the logs. That's why we prefix an [off] to the message manually. As Slack is a kind of log archive as well, we need the same feature there as well. Conceptually speaking the way of selectively blocking individual messages travelling from IRC -> Slack should be implemented the other way around as well: Slack->IRC. However, as most of the community will probably stay on IRC, with only newcomers slacking in, the current feature was more urgent than the other way around.

Ignoring lines starting with [off] is actually a common feature for IRC loggers.

Is there any way to have off-ity in the main repo?

ekmartin commented 7 years ago

I see @MichaelDaum. That definitely makes sense, but I think it's a bit too out of scope for the project. Sorry!