search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 158 forks source link

Fix username sent to IRC : prefer display_name over user.name #214

Open mmarchand opened 6 years ago

mmarchand commented 6 years ago

Try to use display_name (often set to the user's nick) over user.name when it is set

ekmartin commented 6 years ago

The fact that display names can be changed as often as you want, and that they're not unique, makes me slightly nervous. You could change your display name to someone else's username, post a message, and change back.

Or am I missing something here?

mmarchand commented 6 years ago

just like on IRC actually ? ;)

I have had about 100 users that expected to see their display names rather than the username (they are migrating from IRC to a public slack channel) and they could not change their username back to their IRC nickname after creating their account

xrchz commented 6 years ago

I think you may need to augment test/stubs/data-store-stub.js a bit to get the checks to pass.

Stoner19 commented 6 years ago

I seem to be having some similar issues. A Slack user's real name is displayed on IRC when it should be their display name, and if there is a word/string said in IRC that matches something within their registration email (which is hidden from public) it changes that word on slack to their user name.