search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 158 forks source link

Update docker option #220

Closed mrhillsman closed 4 years ago

mrhillsman commented 6 years ago

Closes issue #219 Current docker option has not been updated for some time and requires building image manually. This updates README to point to updated docker option (dockerhub image and manual build). Also, as a new user PR updates flow of README for easier grasp of slack-irc and usage.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.49% when pulling dc7f95011f8d54e85d662249de031190453c544a on mrhillsman:issue/219 into 2b5ceb7ca7beba9190df53c72b9aefb3ba91d6e9 on ekmartin:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.49% when pulling dc7f95011f8d54e85d662249de031190453c544a on mrhillsman:issue/219 into 2b5ceb7ca7beba9190df53c72b9aefb3ba91d6e9 on ekmartin:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.49% when pulling dc7f95011f8d54e85d662249de031190453c544a on mrhillsman:issue/219 into 2b5ceb7ca7beba9190df53c72b9aefb3ba91d6e9 on ekmartin:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.49% when pulling 435eef9f723797ab51d576fe8a02944686ae9b09 on mrhillsman:issue/219 into 2b5ceb7ca7beba9190df53c72b9aefb3ba91d6e9 on ekmartin:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.49% when pulling 435eef9f723797ab51d576fe8a02944686ae9b09 on mrhillsman:issue/219 into 2b5ceb7ca7beba9190df53c72b9aefb3ba91d6e9 on ekmartin:master.

ekmartin commented 6 years ago

Cool, thanks! I think it might be better to have all the Docker info in the external README though, similar to how it was before. Also, why do you have slack-irc as a submodule in your repository? Wouldn't it be easier to just npm install -g slack-irc?

Could also maybe use systemd instead of supervisor - avoids another install, and the configs are pretty simple. See e.g. http://nodesource.com/blog/running-your-node-js-app-with-systemd-part-1/.

mrhillsman commented 6 years ago

I actually spent a little bit of time trying to figure things out and was hoping for docker option as it has become quite normal and ended up researching turning node application into docker container because it was all the way at the bottom of the README :(

Using submodule because the repo is designed to build the docker image rather than manually doing it. Also will allow rebuilding when slack-irc is updated automagically in dockerhub; working on that part.

I can definitely use systemd instead of supervisor but not sure if image will get bloated as a result or any issues will come up going forward since I am pulling node docker image rather than building from scratch; i.e. using an OS container.