search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 158 forks source link

Added feature to create a connection per slack user #238

Open bobvandevijver opened 6 years ago

bobvandevijver commented 6 years ago

I found a single connection from a bot, with the username in the message text to be cumbersome and bad for the readability of the message origin.

This PR adds the ability to create a new connection for every slack user, by using the slack username appended with [s] to indicate the slack integration. The behavior is now more like the behavior on slack, but restrictions from the IRC might apply (maximum connections per host).

A todo is of course tests, but first I would like to know if you would consider merging this feature, or if I should simply keep it in my own fork.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-13.2%) to 86.325% when pulling b1540e8c2b8714a0fa31d45dc3b9f5855ed6fecf on bobvandevijver:connection-per-user into e5cb8c6e83a18b706bd69cef96c5af067a31604a on ekmartin:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-13.2%) to 86.325% when pulling b1540e8c2b8714a0fa31d45dc3b9f5855ed6fecf on bobvandevijver:connection-per-user into e5cb8c6e83a18b706bd69cef96c5af067a31604a on ekmartin:master.