ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
588 stars 158 forks source link

Publishing proper links to images shared from Slack to IRC #244

Open CRImier opened 6 years ago

CRImier commented 6 years ago

As of now, bots can get public URLs for images - the problem is, images aren't automatically shared, so the public links are 404 - until somebody shares them. This effectively prohibits the majority of users on IRC side from seeing the uploaded images - they only see notifications sent by the bot, but visiting the link results in "File not found". This also makes the image link forwarding capability, as it is, kind of useless.

In order to share a file, you need to either go into image properties and press a "Get public link" button or call files.sharedPublicURL from Web API. The problem is - bots can't use files.sharedPublicURL, only users (or apps with appropriate scopes) can do that. So, I've added a capability of using a user token additionally - solely for generating proper, accessible links.