search

ekmartin / slack-irc

Connects Slack and IRC channels by sending messages back and forth.
MIT License
587 stars 155 forks source link

Adding option to disable slack to IRC communication #47

Closed zabirauf closed 9 years ago

zabirauf commented 9 years ago

Added a new option in configuration "silent" to disable Slack to IRC communication.

ekmartin commented 9 years ago

Even though I certainly see how this could be useful, I'm a bit unsure if introducing another configuration option is the right decision. slack-irc should be simple, and every extra configuration option comes with a tiny bit of added complexity.

Besides, shouldn't this really be two configuration options? silent doesn't really say anything about if it's Slack or IRC that it'll stop outputting to. disableSlackOutput and disableIRCOutput would probably be better, but then again, that'd be two new configuration options to the 7 existing ones.

Would be interested in hearing what the rest of the users think, i.e. if there's more people that this would benefit.

zabirauf commented 9 years ago

Yep, added functionality will certainly add more complexity. I agree that we should see if this is something more people want, if so then it would make more sense to merge. Will change the name once we decide to add the functionality.

ekmartin commented 9 years ago

Closing this for now to try to keep a lid on the complexity. Will reopen if more people see this as a needed feature in the future.