RyanGlScott
commented
8 years ago Since you already made a transformers-related pull request, do you mind incorporating the changes needed to replace Data.Functor.Coproduct with Data.Functor.Sum? Here is a git diff of the changes I made to your branch to make it work:
diff --git a/adjunctions.cabal b/adjunctions.cabal
index 62c4368..ee032a8 100644
--- a/adjunctions.cabal
+++ b/adjunctions.cabal
@@ -40,20 +40,21 @@ library
UndecidableInstances
build-depends:
- array >= 0.3.0.2 && < 0.7,
- base >= 4 && < 5,
- comonad >= 4 && < 5,
- containers >= 0.3 && < 0.6,
- contravariant >= 1 && < 2,
- distributive >= 0.4 && < 1,
- free >= 4 && < 5,
- mtl >= 2.0.1 && < 2.3,
- profunctors >= 4 && < 6,
- tagged >= 0.7 && < 1,
- semigroupoids >= 4 && < 6,
- semigroups >= 0.11 && < 1,
- transformers >= 0.2 && < 0.6,
- void >= 0.5.5.1 && < 1
+ array >= 0.3.0.2 && < 0.7,
+ base >= 4 && < 5,
+ comonad >= 4 && < 5,
+ containers >= 0.3 && < 0.6,
+ contravariant >= 1 && < 2,
+ distributive >= 0.4 && < 1,
+ free >= 4 && < 5,
+ mtl >= 2.0.1 && < 2.3,
+ profunctors >= 4 && < 6,
+ tagged >= 0.7 && < 1,
+ semigroupoids >= 4 && < 6,
+ semigroups >= 0.11 && < 1,
+ transformers >= 0.2 && < 0.6,
+ transformers-compat >= 0.3 && < 1,
+ void >= 0.5.5.1 && < 1
exposed-modules:
Control.Comonad.Representable.Store
diff --git a/src/Data/Functor/Adjunction.hs b/src/Data/Functor/Adjunction.hs
index 3ec3fd4..4e18d37 100644
--- a/src/Data/Functor/Adjunction.hs
+++ b/src/Data/Functor/Adjunction.hs
@@ -48,10 +48,10 @@ import Control.Comonad.Trans.Env
import Control.Comonad.Trans.Traced
import Data.Functor.Identity
-import Data.Functor.Coproduct
import Data.Functor.Compose
import Data.Functor.Product
import Data.Functor.Rep
+import Data.Functor.Sum
import Data.Profunctor
import Data.Void
@@ -89,7 +89,7 @@ class (Functor f, Representable u) =>
-- This can be used with the combinators from the @lens@ package.
--
-- @'adjuncted' :: 'Adjunction' f u => 'Iso'' (f a -> b) (a -> u b)@
-adjuncted :: (Adjunction f u, Profunctor p, Functor g)
+adjuncted :: (Adjunction f u, Profunctor p, Functor g)
=> p (a -> u b) (g (c -> u d)) -> p (f a -> b) (g (f c -> d))
adjuncted = dimap leftAdjunct (fmap rightAdjunct)
{-# INLINE adjuncted #-}
@@ -181,12 +181,10 @@ instance (Adjunction f g, Adjunction f' g') =>
counit = rightAdjunct (rightAdjunct getCompose) . getCompose
instance (Adjunction f g, Adjunction f' g') =>
- Adjunction (Coproduct f f') (Product g g') where
- unit a = Pair (leftAdjunct left a) (leftAdjunct right a)
- counit = coproduct (rightAdjunct fstP) (rightAdjunct sndP)
- where
- fstP (Pair x _) = x
- sndP (Pair _ x) = x
+ Adjunction (Sum f f') (Product g g') where
+ unit a = Pair (leftAdjunct InL a) (leftAdjunct InR a)
+ counit (InL l) = rightAdjunct (\(Pair x _) -> x) l
+ counit (InR r) = rightAdjunct (\(Pair _ x) -> x) r
instance Adjunction f u =>
Adjunction (Free f) (Cofree u) where
cnd
ekmett
issue in progress: https://github.com/ekmett/adjunctions/issues/17