search

ekmett / adjunctions

Simple adjunctions
http://hackage.haskell.org/package/adjunctions
Other
44 stars 27 forks source link

Add PolyKinds to Data.Functor.Rep #68

Closed ocharles closed 4 years ago

ocharles commented 4 years ago

Currently Rep (Tagged a) only works for a :: Type, but Tagged (a :: k).

ocharles commented 4 years ago

Thanks for the quick feedback! I didn't actually test this at all, I was just testing the waters. I'll get your changes in and hopefully that'll fix the build :+1:

RyanGlScott commented 4 years ago

I've uploaded distributive-0.6.2 to Hackage, which makes the Distributive instance for Tagged poly-kinded. If you change adjunctions.cabal to impose a lower bound of distributive >= 0.6.2, then I believe this PR should compile.

ocharles commented 4 years ago

I think CI is happy now. I did all of this via the GitHub web UI, so it's probably best squash merging - the history here isn't very interesting.