search

ekmett / bifunctors

Haskell 98 bifunctors, bifoldables and bitraversables
Other
57 stars 42 forks source link

Bad default bitraverse #102

Closed phadej closed 2 years ago

phadej commented 2 years ago

is it worth backporting?

https://github.com/haskell/core-libraries-committee/issues/47#issuecomment-1055634151

RyanGlScott commented 2 years ago

I think backporting that change would be worthwhile. The default implementation is so broken that I can't imagine anyone being heartbroken about its removal.

phadej commented 2 years ago

I think it won't even need a major release as we'd replace one bottom with more obvious one.

RyanGlScott commented 2 years ago

See #103.

phadej commented 2 years ago

Can this be closed, or is there something left?

RyanGlScott commented 2 years ago

Yes, I simply forgot to write "fixes #102" in the commit message. Thanks for the reminder!