search

ekmett / bifunctors

Haskell 98 bifunctors, bifoldables and bitraversables
Other
57 stars 42 forks source link

Require at least semigroups-0.16.2, removes some CPP #84

Closed phadej closed 4 years ago

phadej commented 4 years ago

bifunctors-5.5.7 was failing to compile with older semigroups (look at the diff why).

The corresponding revision is made for 5.5.7 on Hackage.

RyanGlScott commented 4 years ago

Just for reference, what is the build failure that you get when building with older semigroups? It's not obvious to me where the mistake lies.

phadej commented 4 years ago

in Biap module the import is guarded by 

#if MIN_VERSION_base(4,9,0) || MIN_VERSION_semigroups(0,16,2)

but its use isn't.

RyanGlScott commented 4 years ago

Ah, right you are.