search

ekmett / bytes

Serialization primitives that work with both cereal and binary.
http://hackage.haskell.org/package/bytes
Other
22 stars 13 forks source link

Binary orphans #47

Closed phadej closed 5 years ago

phadej commented 5 years ago

I wonder if Semigroups instances should be put into semigroups? Yet, this way it's simpler.

I'm going to repurpose binary-orphans to these needs, and make binary-instances; that way we'll get a bit more consistent package naming

phadej commented 5 years ago

Ok, now there are some legit failures:

src/Data/Bytes/Get.hs:299:10:
    Could not deduce (Fail.MonadFail (Lazy.StateT s m))

are these in some transformers-compat version, @RyanGlScott ?

phadej commented 5 years ago

.Instances ()

phadej commented 5 years ago

I'll do binary-orphans release soon-ish.

phadej commented 5 years ago

binary-orphans is out. The CI is green.

RyanGlScott commented 5 years ago

Many thanks for all your hard work on this!

phadej commented 5 years ago

@RyanGlScott I'd try to build acme-kmett with this. So we'd sure this is 0.16 and not 1.

RyanGlScott commented 5 years ago

I did build bytes' reverse dependencies that live in the Kmettiverse (approximate, bits, bound, compensated, hyperloglog, linear, and log-domain) against this and didn't notice any breakage. But it never hurts to have someone else double-check my work.

phadej commented 5 years ago

acme-kmett built well with GHC-7.4.2, GHC-7.10.3 and GHC-8.6.5