ekmett / bytes

Serialization primitives that work with both cereal and binary.
http://hackage.haskell.org/package/bytes
Other
22 stars 13 forks source link

Fix test failure with bytestring 0.9 #7

Closed snoyberg closed 11 years ago

snoyberg commented 11 years ago

The Show instance for lazy ByteStrings in 0.9 includes Chunk and Empty garbage, which caused the tests to fail. This hacky solution is to convert the lazy ByteString into a strict ByteString. There might be better solutions, but I couldn't think of any.

Note that conditional compilation doesn't seem to play well with doctests.

ekmett commented 11 years ago

Shipped. 0.11.5 is on hackage.

ekmett commented 11 years ago

I've added you to the committers list to ease your development process.

Feel free to push directly for non-controversial changes and just submit pull requests when you think there may need to be discussion.