ekmett / contravariant

Haskell 98 contravariant functors
http://hackage.haskell.org/package/contravariant
Other
73 stars 24 forks source link

Attempt to provide some intuition for contravariant and divisible #33

Closed ocharles closed 7 years ago

ocharles commented 7 years ago

There was recently confusion (and, as I read it, frustration) on Twitter regarding Contravariant and Divisible.

I provided a few tweet replies, but this comes up time and time again. @tomjaguarpaw has explained 'Contravariant' once (https://ocharles.org.uk/blog/guest-posts/2013-12-21-24-days-of-hackage-contravariant.html), @phaazon spoke about divisible (https://phaazon.blogspot.co.uk/2015/08/contravariance-and-luminance-to-add.html), but I think it's about time we bought at least some of this into contravariant proper.

Yes, the examples do not do justice to what a Contravariant functor truly is, but I believe they provide at least a gentle ramp to begin wading towards the deep end. I will understand if you feel this is the wrong place for this documentation.

@jb55 this is written for you, so I'd appreciate knowing if it even helps. @acowley expressed not knowing what Divisible even was, so likewise feedback would be appreciated.

tomjaguarpaw commented 7 years ago

This is sorely needed.

acowley commented 7 years ago

Thanks so much for taking action on this @ocharles! I had forgotten about @phaazon’s blog post, and it really is an excellent example. If linking to such things from the docs is viewed as okay, I’d be in favor of doing so.

Blaisorblade commented 7 years ago

Thanks a lot for this! That's the sort of thing we need more of. If I may ask: do you also understand Decidable?

jb55 commented 7 years ago

I haven't decided to dive into that yet but it looks more approachable 👍

hadronized commented 7 years ago

Feel free to use my blog post, of course! :)

I just re-read it, and found the comments below. Oh my. :D

ekmett commented 7 years ago

I have no particular objection to including links to blog posts about the topic.

ocharles commented 7 years ago

@Blaisorblade yes, I'll do Decidable too, if people feel this is useful. It's not much of a step up from Divisible.

ocharles commented 7 years ago

Ok, I've added an explanation for Decidable too, and addressed @phadej's point that my Divisible example doesn't actually show a use of divide.

RyanGlScott commented 7 years ago

This looks nice overall. I have one gripe in that these changes move the laws for Decidable and Divisible away from their Haddocks and sequesters them elsewhere. I'd prefer to keep the laws close to the classes themselves, although I don't care if they're accompanied by the current category theoretic jargon or not. I'd be OK with repeating the laws in the additional section you've added, but explained in further detail.

ocharles commented 7 years ago

Agree, I think the laws should be front and center. I'll try and move them

On Sun, 24 Sep 2017, 2:56 pm Ryan Scott notifications@github.com wrote:

This looks nice overall. I have one gripe in that these changes move the laws for Decidable and Divisible away from their Haddocks and sequesters them elsewhere. I'd prefer to keep the laws close to the classes themselves, although I don't care if they're accompanied by the current category theoretic jargon or not. I'd be OK with repeating the laws in the additional section you've added, but explained in further detail.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ekmett/contravariant/pull/33#issuecomment-331711704, or mute the thread https://github.com/notifications/unsubscribe-auth/AABRjhUvIaeMfjxZWZwAF3FWb29z00Bwks5sll9WgaJpZM4Pdxy0 .

mitchellwrosen commented 7 years ago

Is this still being worked on? If so, there's a pattern I've used in the past to make Divisible feel more like Applicative that might be worth mentioning in some sort of tutorial. I'm not sure.

-- Right fixity, higher than >$<
infixr 5 >*<
(>*<) :: Divisible f => f a -> f b -> f (a, b)
(>*<) = divided

Here's how you use it:

data Person = Person
  { name :: String
  , age :: Int
  , living :: Bool
  }

longName :: Predicate String
longName = Predicate (\name -> length name > 8)

old :: Predicate Int
old = Predicate (\age -> age > 60)

alive :: Predicate Bool
alive = Predicate id

oldAndAliveWithLongName :: Predicate Person
oldAndAliveWithLongName =
  (\p -> (name p, (age p, living p)))
    >$< longName
    >*< old
    >*< alive
tomjaguarpaw commented 7 years ago

@mitchellwrosen I have to say I don't like that at all. Why not


(<||>) :: Divisible f => f a -> f a -> f a
(<||>) = divide (\x -> (x, x))

oldAndAliveWithLongName :: Predicate Person
oldAndAliveWithLongName = contramap name longName
                     <||> contramap age old
                     <||> contramap living alive

[Not type checked!]

jb55 commented 7 years ago

@tomjaguarpaw yours is cleaner, @mitchellwrosen's fits the Applicative analogy a bit better from a learning perspective

tomjaguarpaw commented 7 years ago

It only feels like Applicative until you actually try to use it, at which point you notice you can never get rid of the tuple nesting because they type parameter is contravariant. Then it becomes too painful to use.

mitchellwrosen commented 7 years ago

That's a good operator too, but it looks more like <> for the Monoid that every Divisible gives rise to, so I don't think it needs its own name.

mempty = conquer
mappend = divide (\x -> (x, x))

(except that Predicate isn't a Semigroup/Monoid right now)

phadej commented 7 years ago

For Predicate, deriving via a -> All or a -> Any instances also makes sense. So it's not an easy choice.

EDIT or will they boil down to the same instance?

mitchellwrosen commented 7 years ago

Wouldn't the more natural/obvious Monoid instance correspond to a -> All, per how Predicate's Divisible instance works?

tomjaguarpaw commented 7 years ago

Maybe, but that's just shifting the observation to "there are two choices of Divisible instance"!

mitchellwrosen commented 7 years ago

Of course, but it's odd to mix-and-match the two, no? Anywho, I feel like I am spamming this issue unnecessarily :) Thanks for the discussion!

On Oct 17, 2017 6:13 PM, "tomjaguarpaw" notifications@github.com wrote:

Maybe, but that's just shifting the observation to "there are two choices of Divisible instance"!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ekmett/contravariant/pull/33#issuecomment-337389718, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBlpvloNxFvyZSVDM52kUGCAoTOXby7ks5stSZxgaJpZM4Pdxy0 .

ocharles commented 7 years ago

Yes, this is being worked on, but the scope of this PR is to just improve documentation. All I need to do is add the laws, and I'm done. I'll happily take a patch from anyone else adding those laws, too.

ekmett commented 7 years ago

I'd say the Monoid for any of these should match up with the conquer and divide delta if they are missing. This corresponds exactly to what you'd derive if you used (a -> All) and (a -> a -> All) and (a -> a -> Ordering), etc. I'm actually surprised I didn't add them.

ekmett commented 7 years ago

Ah, we're just missing the Predicate one. Adding it. (Off topic digression ends)

ekmett commented 7 years ago

Merged what you have. We can do more intensive edits as we go.

ekmett commented 7 years ago

@ocharles you have commit access to the repo now, feel free to push further updates directly.

jb55 commented 7 years ago

Thanks guys!

hadronized commented 7 years ago

\o/