search

ekmett / distributive

Dual Traversable
http://hackage.haskell.org/package/distributive
Other
41 stars 25 forks source link

Require at least transformers-0.3 #56

Closed phadej closed 4 years ago

phadej commented 4 years ago

This allows to drop transformers-compat dependency, and also fixes build on GHC-7.8.4, which allowed picking transformers-0.2, and thus making Data.Distributive module fail to compile.

Note: transformers-0.3 is the oldest release any GHC ships, so this change doens't affect installed constrained builds.

Affected versions: 0.6 0.6.1 0.6.2 Corresponding revision made on Hackage.

RyanGlScott commented 4 years ago

Thanks. Would this require a new release on Hackage? I noticed that while your revision bumped the lower bound on transformers to >= 0.3, it didn't remove this part:

  if !impl(ghc >= 7.8) && !impl(ghcjs)
    build-depends: transformers-compat >= 0.3 && < 1

Would this be problematic?

phadej commented 4 years ago

One cannot remove dependencies in revisions. I don't think the release is necessary. There is unneeded dependency, but GHC affected are ancient, so it can wait until there is some other reason to make release too.