ekmett / ersatz

A monad for interfacing with external SAT solvers
Other
63 stars 15 forks source link

improve Ersatz.Relation (docs, features) - or break out? #71

Closed jwaldmann closed 9 months ago

jwaldmann commented 2 years ago

I have a student working on Ersatz.Relation, and some doc fixes incoming (this week).

There will also be additions (properties of relations that are used in abstract rewriting systems) - perhaps this is best done in a separate package (but it would be quite small).

Should Ersatz.Relation be broken out of ersatz as well? (It was not there to begin with.) This would reduce cognitive load for users and maintainers of the core library - and reduce churn of version numbers! (by PVP, have to update on API changes)

jwaldmann commented 1 year ago

@RyanGlScott what's your opinion here? perhaps related - what are your criteria/plans for making releases on hackage?

RyanGlScott commented 1 year ago

I don't have a particularly strong feeling about whether Ersatz.Relation belongs in a separate library or not. I'm personally not too bothered by needing to bump the major version number for the ersatz library, as I don't think there are too many projects that depend on ersatz currently. That being said, if you think these upcoming additions to Ersatz.Relation would be useful outside of the context of ersatz's core SAT solving functionality, perhaps that is a convincing argument in favor of splitting out Relation.

RyanGlScott commented 1 year ago

As far as Hackage releases go, I would be happy to make a new release whenever you want one. I could also give you Hackage upload permissions if that would make things easier.

jwaldmann commented 1 year ago

OK, please make a hackage release - the haddock improvements might help students in my course, right now.

RyanGlScott commented 1 year ago

I've uploaded ersatz-0.4.13 to Hackage.